introduce Client.methodCallWithTransport #123
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Essentially changes Client.methodCall to take a specific transport object which is used to perform the request. This enables one to use a transport other than HTTP or HTTPS, for example, SCGI. The original Client.methodCall is now implemented in terms of this new method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had forgotten that I had contributed to this project many years ago 😄
I really need to be able to perform requests via SCGI instead of HTTP. I was originally doing this by explicitly requiring
xmlrpc/lib/Client, Deserializer, and so on to attach my ownscgiMethodCallto the Client's prototype, but I figured that this might be a cleaner way.Essentially changes Client.methodCall to take a specific transport
object which is used to perform the request. This enables one to use a
transport other than HTTP or HTTPS, for example, SCGI.
The original Client.methodCall is now implemented in terms of this new
method.