Use Octokit for authorization and fix 2FA bug. #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tomorrow will finally be the day that I can come back to git-review. Thanks for your patience. |
b4mboo
pushed a commit
that referenced
this pull request
Mar 28, 2014
Use Octokit for authorization and fix 2FA bug.
|
Nice and clean. Thank you. (And sorry for the delay.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User authorization process is simplified.
Git-review will first attempt to find Github username from local git config files. The authorization is mainly handled by Octokit, including Github's 2FA, as Octokit will be able to identify, from the response, whether the an OTP is required.
This fixes bug #84.