[aws-cpp-sdk-core]: increase STS reliability and retries #2611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes issues we have repeatedly experienced when using STS for authentication in a large Kubernetes cluster, with heavy load on STS: 1. The default connect timeout of 1s is too low. It happens that connections slow down. One case is very high load on kube DNS. A value of 30 seconds has proven to be robust. 2. The retry parameters are too short, authentication would frequently fail whenever STS was under higher load. The retry settings have worked in production for about 2 years.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issues we have repeatedly experienced when using STS for authentication in a large Kubernetes cluster, with heavy load on STS:
Check all that applies:
We have before/after experience. Without these settings, calls to STS would frequently time out whenever STS was under higher load.
Within the close to 2 years after making this change, we no longer experienced authentication failures when STS was under load.
Check which platforms you have built SDK on to verify the correctness of this PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.