-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC605: EKS L2 Rewrite #646
Conversation
Pull request has been modified.
Co-authored-by: Eli Polonsky <[email protected]>
Co-authored-by: Eli Polonsky <[email protected]>
Is EKS Auto Mode supported in the new construct? |
Yes because |
Thanks! This sounds good. Is there any estimate for the release with Auto Mode? |
The current estimate is 2025 Q1. |
text/0605-eks-rewrite.md
Outdated
Grant Admin Access to an IAM role | ||
|
||
``` | ||
cluster.grantAdmin('adminAccess', roleArn, eks.AccessScopeType.CLUSTER); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we make the second argument here accept an IGrantable and not a string?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this function return something? an AccessEntry
maybe?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the access scope argument mandatory? what would be the API for granting admin on a specific namespace?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This API is basically the current grantAccess()
with hardcode values: https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.aws_eks.Cluster.html#grantwbraccessid-principal-accesspolicies
Can we make the second argument here accept an IGrantable and not a string?
Yes I agree.
Does this function return something? an
AccessEntry
maybe?
It's the same as current API which is void
.
Is the access scope argument mandatory? what would be the API for granting admin on a specific namespace?
Actually I think we should remove the third argument to make grantAdmin()
easier to use. So something like:
cluster.grantAdmin('adminAccess', role);
It will add AmazonEKSClusterAdminPolicy
to the role. There's also AmazonEKSAdminPolicy which can be applied to a namespace. Have 2 grantAdmin
is a bit confusing. Customers can use the general grant method for granting admin on a specific namespace. We can add moregrantXXX()
later.
Co-authored-by: Eli Polonsky <[email protected]>
Co-authored-by: Eli Polonsky <[email protected]>
Co-authored-by: Eli Polonsky <[email protected]>
Co-authored-by: Eli Polonsky <[email protected]>
Co-authored-by: Eli Polonsky <[email protected]>
Co-authored-by: Eli Polonsky <[email protected]>
This is a request for comments about Rewrite EKS L2 Construct. See #605 for additional details.
APIs are signed off by @iliapolo.
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache-2.0 license