Adding Lint Checker #1449
Merged
Adding Lint Checker #1449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jefchien
approved these changes
Dec 3, 2024
Comment on lines
50
to
51
| - gofmt | ||
| - goimports |
There was a problem hiding this comment.
nit: Likely don't need these linters since we have other steps that'll check/fix them, which is why these were initially disabled.
dricross
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Issue
Currently, the CloudWatch Agent only performs basic linting checks. This pull request introduces an enhanced lint checker to ensure that all future code merges adhere to high standards of formatting and quality.
Since the current codebase may contain existing linting conflicts, a parameter
new-from-devhas been introduced, set to the commit3221f769358168c0602e58918c1fb7b6083e33af. This parameter ensures that lint checks are only applied to commits made after this point, avoiding unnecessary conflicts with legacy code.Description of Changes
License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution under the terms of your choice.
Requirements
Before committing the code, please complete the following steps:
make fmtandmake fmt-sh.make lint.This version improves clarity, grammar, and professionalism while maintaining the necessary technical details.