End-to-End Build Workflow #1416
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
musa-asad
reviewed
Nov 8, 2024
musa-asad
previously approved these changes
Nov 8, 2024
Co-authored-by: Musa <[email protected]>
|
This PR was marked stale due to lack of activity. |
jefchien
reviewed
Nov 25, 2024
| @@ -96,7 +103,7 @@ jobs: | |||
| StartApplicationSignalsE2ETests: | |||
| needs: [ BuildAndUploadPackages, BuildAndUploadITAR, BuildAndUploadCN, BuildDocker ] | |||
| # Workflow only runs against main | |||
| if: ${{ contains(github.ref_name, 'main') }} | |||
| if: ${{ contains(github.ref_name, 'main') && inputs.test-image-before-upload}} | |||
There was a problem hiding this comment.
What happens if the workflow is started via workflow_dispatch which doesn't have the test-image-before-upload field defined?
musa-asad
reviewed
Dec 1, 2024
| workflow_call: | ||
| inputs: | ||
| operator-branch: | ||
| required: true |
There was a problem hiding this comment.
If we have a default, does it need to be required?
musa-asad
reviewed
Dec 1, 2024
Comment on lines
+7
to
+8
| ECR_TARGET_ALLOCATOR_STAGING_REPO: ${{ vars.ECR_TARGET_ALLOCATOR_STAGING_REPO}} | ||
| ECR_OPERATOR_RELEASE_IMAGE: ${{ vars.ECR_TARGET_ALLOCATOR_TEST_OPERATOR_REPO}} |
There was a problem hiding this comment.
Are these going to be used?
musa-asad
reviewed
Dec 1, 2024
| secrets: inherit | ||
| with: | ||
| tag: ${{needs.GetLatestOperatorCommitSHA.outputs.operator_commit_sha}} | ||
| target-branch: ${{needs.GetLatestOperatorCommitSHA.outputs.operator_commit_sha}} |
There was a problem hiding this comment.
Suggested change
| target-branch: ${{needs.GetLatestOperatorCommitSHA.outputs.operator_commit_sha}} | |
| target-sha: ${{needs.GetLatestOperatorCommitSHA.outputs.operator_commit_sha}} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue
Allows us to build and test with operator for full end-to-end testing
Description of changes
Added new workflow to build agent and operator together
License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
https://github.com/aws/amazon-cloudwatch-agent/actions/runs/11748578760
Requirements
Before commit the code, please do the following steps.
make fmtandmake fmt-shmake lint