Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed missing phone number in Django Shop Plugin #863

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

shivamraj74
Copy link

Missing phone number option in link plugin #861 Django Shop plugin is missing due to overriding the LinkForm.LINK_TYPE_CHOICES property. By letting add to LinkForm if the phone number exists.

Missing phone number option in link plugin awesto#861 Django Shop plugin is missing due to overriding the LinkForm.LINK_TYPE_CHOICES property.
@execut
Copy link
Contributor

execut commented Aug 30, 2021

@shivamraj74 I already fixed it bug here #862. I think my solution is more correct since it eliminates duplication of the parent's code.

@shivamraj74
Copy link
Author

I think simply eliminating the parent's code, could not arise security issues?

@execut
Copy link
Contributor

execut commented Aug 30, 2021

I think simply eliminating the parent's code, could not arise security issues?

I don't quite understand how this can cause security problems. Please, show me an example.

@shivamraj74
Copy link
Author

Well, it was missing due to overriding of class LinkForm property, so I basically corrected at cascade plugin and now let the owner decide it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants