-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dynamic payment modifier valid option updates #600
base: master
Are you sure you want to change the base?
Conversation
Please be patient on this pull request. |
I've noticed the "Purchase" button no longer works on my implementation, but seems to work on the example.. |
The "Purchase" button is now working on my project too. I noticed some differences in the settings between my project and the example project. It could have been that or something else that fixed it. Possibly the addition of the fontawesome iconfont? |
This requires some changes to work properly, for example it is possible to select a payment option radio button, change the conditions so that the radio button gets disabled yet the form still validates successfully. Ideally form validation would fail forcing the user to select a valid payment option. |
Now also rebased on 0.11.dev0 here |
Feel free to remind me. There was too much stuff awaiting for 0.11 |
Payment modifier
is_disabled()
changes will be reflected in radio options being disabled dynamically.This has specifically been developed to allow changes in shipping modifier to dynamically affect the available payment modifiers and is a solution to issue #592 -
Shipping modifier:
Payment modifier: