Check #email_address for sidebar name #3340
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rails 8's new baked in authentication implementation uses user#email_address by default, so I figured it would be nice to support that by default in Avo as well to make things feel seamless for the new release. This is a pretty lightweight PR but please let me know if you've like a section in the docs specific to supporting the new baked in authentication since the manual testing steps below are juuuuust fiddly enough to maybe merit their own section.
Checklist:
Screenshots & recording
Manual review steps
bin/rails generate authentication
Current.user
for thecurrent_user_method
andsession_path
for thesign_out_path_name
.main_app.
to any redirects in the Authentication concern.Manual reviewer: please leave a comment with output from the test if that's the case.