Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run i18n_specs in a separate job #2966

Merged
merged 2 commits into from
Jul 15, 2024

Conversation

binarygit
Copy link
Contributor

@binarygit binarygit commented Jul 11, 2024

Description

Creates a separate job to run i18n specs.

Fixes #2957

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

Screenshots & recording

Manual review steps

  1. Step 1
  2. Step 2

Manual reviewer: please leave a comment with output from the test if that's the case.

Copy link

codeclimate bot commented Jul 11, 2024

Code Climate has analyzed commit 9b9c964 and detected 0 issues on this pull request.

View more on Code Climate.

@binarygit binarygit force-pushed the extract-translation-tests branch 3 times, most recently from a70e61d to 15ff5e5 Compare July 11, 2024 05:59
@binarygit binarygit marked this pull request as ready for review July 11, 2024 06:28
Copy link
Contributor

@Paul-Bob Paul-Bob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right now any error in the i18n test will cancel the system tests

Let's do a separate workflow file for the i18n.

@binarygit
Copy link
Contributor Author

Hey @Paul-Bob, error in either the system tests or the i18n one wouldn't have affected either jobs.
image

But I extracted out the test to a separate workflow because there was no advantage in keeping it as a job compared to a workflow. I also think it's easier to read the file now that it's a workflow. Thanks for your suggestion! 😄

@binarygit binarygit requested a review from Paul-Bob July 15, 2024 04:57
@adrianthedev adrianthedev merged commit 4b9d7b0 into avo-hq:main Jul 15, 2024
21 of 22 checks passed
@Paul-Bob Paul-Bob added the Chore label Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extract the i18n tests from system to their own category
3 participants