Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable insecure client remote tests #194

Open
tstirrat15 opened this issue Sep 4, 2024 · 0 comments
Open

Re-enable insecure client remote tests #194

tstirrat15 opened this issue Sep 4, 2024 · 0 comments

Comments

@tstirrat15
Copy link
Contributor

Description

The tests were added in #193, but I wasn't able to get the tests that talk to a "remote" docker container working in CI. Github Actions don't provide a lot of handles on a service container (namely that I can't override the COMMAND provided to the container), and the SpiceDB container that our private action sets up is "local."

@vroldanbet suggested that we might be able to use a testcontainer to do the bootstrapping from within the test; pytest would certainly support that decently well with its fixtures. I think the difficult part would be figuring out what network interface to bind to, but that sounds like a surmountable problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant