-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Insecure Client for Convenience #193
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tstirrat15
changed the title
89 manual credential setup
Add Insecure Client for Convenience
Sep 3, 2024
vroldanbet
approved these changes
Sep 4, 2024
tstirrat15
force-pushed
the
89-manual-credential-setup
branch
from
September 4, 2024 14:44
5a5f2ea
to
e667577
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #89
Description
One thing that most users of our library run into is that you can't use client credentials in a non-TLS context with the way that the Python gRPC lib is designed. This was likely intentional; network sniffing can turn into credential exposure in a production environment. However, it's frustrating and inconvenient when all you want to do is try out the lib using
docker-compose
.This provides an
InsecureClient
that implements a workaround for those contexts.Changes
InsecureClient
to allow for the use caseTesting
Review. See that tests pass and that you can set up a connection with the
InsecureClient
.