Remove lockfiles #168
Merged
Remove lockfiles #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#166 is an example of how a breakage can show up for a user without having showed up in our tests. Because we're pinning in the lockfile, but the package request in
package.jsonis compatible with a new version of grpc-js that has meaningfully different behavior, we didn't see test failures even though there was breakage.Removing the lockfile should mean that our test runs are more faithful to the user experience.
Changes
Testing
Review. See that our tests break because we don't yet have the fix from #167.