Support for listing authenticators and deleting specific authenticator #698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frederikprijck
requested changes
Jan 10, 2024
Comment on lines
508
to
516
| if (string.IsNullOrEmpty(request.AccessToken)) | ||
| { | ||
| throw new InvalidOperationException($"{nameof(request.AccessToken)} is required"); | ||
| } | ||
|
|
||
| if (string.IsNullOrEmpty(request.AuthenticatorId)) | ||
| { | ||
| throw new InvalidOperationException($"{nameof(request.AuthenticatorId)} is required"); | ||
| } |
There was a problem hiding this comment.
We do not need to introduce this kind of validation here.Currently, we rely on the backend to tell us if something is missing, mainly because it isn't always clear what is and isnt required.
|
Can we also add some consistency around naming here? |
5 tasks
renamed to ListMfaAuthenticatorsAsync |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adding support for listing authenticators and deleting specific authenticator
Added new methods to authentication client to support the API endpoints
Added request/response classes
References
Please include relevant links supporting this change such as a:
resolves #696
resolves #697
Testing
Please describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.
This change adds integration test coverage
This change has been tested on the latest version of the platform/language or why not
Checklist
I have read the Auth0 general contribution guidelines
I have read the Auth0 Code of Conduct
All existing and new tests complete without errors