Refactor telemetry to collect events during DAG run and not DAG parsing #300
+100
−62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pankajastro
force-pushed
the
telemetry_event
branch
2 times, most recently
from
346b6f7 to
97d6cad
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #300 +/- ##
==========================================
- Coverage 93.38% 92.57% -0.82%
==========================================
Files 8 10 +2
Lines 680 700 +20
==========================================
+ Hits 635 648 +13
- Misses 45 52 +7 ☔ View full report in Codecov by Sentry. |
tatiana
reviewed
Nov 27, 2024
tatiana
reviewed
Nov 29, 2024
tatiana
reviewed
Nov 29, 2024
tatiana
reviewed
Dec 3, 2024
pankajastro
commented
Dec 3, 2024
pankajastro
commented
Dec 3, 2024
pankajastro
force-pushed
the
telemetry_event
branch
from
6afa937 to
bc1578d
Compare
tatiana
changed the title
tatiana
approved these changes
Dec 3, 2024
There was a problem hiding this comment.
Great work, @pankajastro , happy for us to merge the PR once the docs (https://github.com/astronomer/dag-factory/blob/main/PRIVACY_NOTICE.md) are updated.
pankajastro
force-pushed
the
telemetry_event
branch
from
599dc18 to
1eee294
Compare
Updated the docs |
tatiana
changed the title
Merged
tatiana
added a commit
that referenced
this pull request
Dec 6, 2024
### Added - Add support to TaskFlow and improve dynamic task mapping support by @tatiana in #314 - Render YML DAG config as DAG Docs by @pankajastro #305 - Support building DAGs out of topologically unsorted YAML files by @tatiana in #307 - Add support for nested task groups by @glazunov996 and @pankajastro in #292 - Add support for templating `on_failure_callback` by @jroach-astronomer #252 ### Fixed - Fix compatibility with apache-airflow-providers-cncf-kubernetes>=10.0.0 by @tatiana in #311 - Refactor telemetry to collect events during DAG run and not during DAG parsing by @pankajastro #300 ### Docs - Fix reference for HttpSensor in README.md by @pankajastro in #277 - Add example DAG for task group by @pankajastro in #293 - Add CODEOWNERS by @pankajkoti in #270 - Update CODEOWNERS to track all files by @pankajkoti in #276 - Modified Status badge in README by @jaejun #298 ### Others - Refactor dynamic task mapping implementation by @tatiana in #313 - Remove pytest durations from tests by @tatiana in #309 - Remove DAG retries check since many DAGs have different retry values by @tatiana in #310 - Lint fixes after running `pre-commit run --all-files` by @tatiana in #312 - Remove redundant exception code by @pankajastro #294 - Add GitHub issue template for bug reports and feature requests by @pankajkoti in #269 Closes: #223
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DAG Factory 0.20 started collecting telemetry as part of the PR #250. However, one limitation of this initial implementation is that it emitted telemetry every time DAGs were parsed. This means that the data collected did not represent the actual usage and was proportional to the number of times a DAG was parsed. This PR aims to address this limitation by changing DAG Factory to emit telemetry during DAG runs.
This implementation leverages Airflow listeners to only emit events after a Factory-Built DAG is run.
Closes: #282
With this data, we can get the following insight
Airflow Version
DAG Hash
DAG Factory Version
Event Type
Platform Machine
Platform System
Python Version
DAG Run Status
Task Count in DAG run
** Telemetry Version**
