Correctly handle producing multiple Venvs for the same python version #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I had about 80% of the approach implemented from day one - we already checked a map to see if we'd already seen that version. The problem was we never set anything in it so it was always empty. This also tidies up the tests a bit, and removes the needless link to `/usr/local/include/python3.7m` for >=Py3.8 (which doesn't need it) I used `coreos/go-semver` for Semver parsing as that was already in our dep tree
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had about 80% of the approach implemented from day one - we already
checked a map to see if we'd already seen that version. The problem was
we never set anything in it so it was always empty.
This also tidies up the tests a bit, and removes the needless link to
/usr/local/include/python3.7mfor >=Py3.8 (which doesn't need it)I used
coreos/go-semverfor Semver parsing as that was already in ourdep tree
Fixes #29