Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: upgrade to new v1 protos #19

Merged
merged 5 commits into from
Oct 17, 2024
Merged

chore: upgrade to new v1 protos #19

merged 5 commits into from
Oct 17, 2024

Conversation

joroshiba
Copy link
Member

@joroshiba joroshiba commented Oct 16, 2024 •
edited
Loading

Note: update to use main again before merging

@joroshiba joroshiba requested review from noot and SuperFluffy October 16, 2024 21:21
SuperFluffy
SuperFluffy approved these changes Oct 17, 2024
View reviewed changes
Copy link
Member

@SuperFluffy SuperFluffy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but let's set rev instead of branch after we tag a release on the main repo.

@joroshiba joroshiba merged commit d16d26a into astria Oct 17, 2024
6 of 32 checks passed
@joroshiba joroshiba deleted the joroshiba/protobuf-updates branch October 17, 2024 14:45
@joroshiba joroshiba mentioned this pull request Oct 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperFluffy SuperFluffy SuperFluffy approved these changes

@noot noot Awaiting requested review from noot

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joroshiba @SuperFluffy