feat: support new API utilizing rollup data #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noot
reviewed
Mar 16, 2024
| @@ -336,3 +359,7 @@ func ethHeaderToExecutionBlock(header *types.Header) (*astriaPb.Block, error) { | |||
| }, | |||
| }, nil | |||
| } | |||
|
|
|||
| func (s *ExecutionServiceServerV1Alpha2) syncMethodsCalled() bool { | |||
There was a problem hiding this comment.
is this related to the rollup data functionality or was it needed for something else?
There was a problem hiding this comment.
This isn't needed for rollup functionality, but added to stop us from accidentally executing over bad state in case of something like Geth reboots but conductor didn't and txs/blocks lost.
noot
approved these changes
Mar 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces two new features:
Note: before merge need to upgrade to release proto version, built on top of a PR buf version