Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable SVC annotations on faucet and graph-node #1872

Merged
merged 9 commits into from
Dec 11, 2024

Conversation

WafflesVonMaple
Copy link
Contributor

Summary

Add ability to annotate services for internal or external use differentiation

Changes

  • Changes to helper.tpl and service templates to enable annotation

@github-actions github-actions bot added the cd label Dec 11, 2024
@WafflesVonMaple WafflesVonMaple marked this pull request as ready for review December 11, 2024 19:50
@WafflesVonMaple WafflesVonMaple requested a review from a team as a code owner December 11, 2024 19:50
Copy link
Contributor

@quasystaty1 quasystaty1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, small newline nits

charts/evm-faucet/templates/_helper.tpl Outdated Show resolved Hide resolved
charts/graph-node/templates/_helpers.tpl Outdated Show resolved Hide resolved
charts/sequencer-faucet/templates/_helpers.tpl Outdated Show resolved Hide resolved
@WafflesVonMaple WafflesVonMaple added this pull request to the merge queue Dec 11, 2024
Merged via the queue into main with commit 311d358 Dec 11, 2024
46 checks passed
@WafflesVonMaple WafflesVonMaple deleted the teleport_svc_annotation branch December 11, 2024 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants