Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump to rust version 1.83 #1857

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

chore: bump to rust version 1.83 #1857

wants to merge 4 commits into from

Conversation

ethanoroshiba
Copy link
Contributor

@ethanoroshiba ethanoroshiba commented Dec 6, 2024 •
edited
Loading

Summary

Bumped MSRV to 1.83 and made small changes to appease new Clippy lints.

Background

Rust 1.83 solves some bizarre Clippy false positives, improved lints also revealed some nit improvement points. Bumping MSRV also doesn't have a huge cost, since we don't have many downstream users.

Changes

  • Bumped MSRV.
  • Changed small bits to appease Clippy, mostly changing to use implicit lifetimes.
  • rustfmt made a bunch of changes with the new version

Testing

Passing all tests.

Changelogs

Changelogs updated for crates which have already been released.

Related Issues

closes #1580

@github-actions github-actions bot added ci issues that are related to ci and github workflows conductor pertaining to the astria-conductor crate proto pertaining to the Astria Protobuf spec sequencer pertaining to the astria-sequencer crate sequencer-relayer pertaining to the astria-sequencer-relayer crate composer pertaining to composer labels Dec 6, 2024
@ethanoroshiba ethanoroshiba removed the proto pertaining to the Astria Protobuf spec label Dec 6, 2024
@ethanoroshiba ethanoroshiba marked this pull request as ready for review December 6, 2024 20:18
@ethanoroshiba ethanoroshiba requested review from a team, joroshiba and noot as code owners December 6, 2024 20:18
This was referenced Dec 6, 2024
Open
Closed
Open
@ethanoroshiba ethanoroshiba requested a review from a team as a code owner December 11, 2024 16:22
@github-actions github-actions bot added the proto pertaining to the Astria Protobuf spec label Dec 11, 2024
@ethanoroshiba ethanoroshiba changed the title chore: bump MSRV chore: bump to rust version 1.83 Dec 11, 2024
@ethanoroshiba ethanoroshiba removed the proto pertaining to the Astria Protobuf spec label Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperFluffy SuperFluffy Awaiting requested review from SuperFluffy SuperFluffy is a code owner

@joroshiba joroshiba Awaiting requested review from joroshiba joroshiba is a code owner

@noot noot Awaiting requested review from noot noot is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
ci issues that are related to ci and github workflows composer pertaining to composer conductor pertaining to the astria-conductor crate override-freeze sequencer pertaining to the astria-sequencer crate sequencer-relayer pertaining to the astria-sequencer-relayer crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

remove allow_attributes false positive exceptions once Rust is updated
1 participant
@ethanoroshiba