latest Auctioneer binary with CI #1855
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
the intended way to communicate with a single server is by multiplexing over one connection. this also modifies the executed stream to not also forward something to another stream (happening outside of it, in the optimistic executor broker)
all streams were Unpin anyways
also makes pushing into the duplex stream a method on on the stream (rather than on handle to it). moves conversion of optimistic to base block to outside the channel so that it doesn't get swallowed (the error event would be happening in a long-running span, if under any span at all).
The "optimistic executioner" task was an extra indirection that provided no clear benefit over just running all stream directly in the auctioneer task.
Also removes auction Handle and Builder - they add unnecessary complexity.
…nnection timeouts so the spans actually end
it was only emitted inside the future constructed by the closure used to start the reconnection. Returning it means a downstream user can explicitly log it. The next invocation of RestartingStream::next will then return Ready(None).
Auctions are very short lived tasks: it does not matter if their channels are bounded or not. After a short period they will end and their memory freed.
…uction steps the oneshot channels communicate cleanly what's happening inside the auction and it's easier to track what was already sent to the auction worker (to reject even triggering other steps on the worker from in its handle).
the trigger to start the auction timer comes from the sequencer block commitment. the trigger to start bids comes from the rollup executing the optimistic block in time. this means that the timer must start running independently of whether or not the rollup returned with the the executed block in time.
…r: just log and return
bharath-123
force-pushed
the
ENG-824/auctioneer-with-ci
branch
from
c7b08fe to
fb56724
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Brief summary of the changes made, ie "what?"
Background
Brief background on why these changes were made, ie "why?"
Changes
Testing
How are these changes tested?
Changelogs
Ensure all relevant changelog files are updated as necessary. See
keepachangelog for change
categories. Replace this text with e.g. "Changelogs updated." or "No updates
required." to acknowledge changelogs have been considered.
Metrics
Breaking Changelist
Related Issues
Link any issues that are related, prefer full GitHub links.
closes