fix(charts): configurable components block times variables #1827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WafflesVonMaple
approved these changes
Dec 12, 2024
joroshiba
approved these changes
Dec 12, 2024
charts/evm-rollup/values.yaml
Outdated
| @@ -172,6 +172,8 @@ config: | |||
| # The expected fastest block time possible from sequencer, determines polling | |||
| # rate. | |||
| sequencerBlockTimeMs: 2000 | |||
| # The expected fastest block time possible from DA, determines polling rate. | |||
| celestiaBlockTimeMs: 12000 | |||
There was a problem hiding this comment.
Probably update this default.
There was a problem hiding this comment.
Should update celestia-local blocktime as well then
quasystaty1
force-pushed
the
quasystaty1/charts/configurable-blocktime
branch
from
c2dcc10 to
2c7f38f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Configurable block time environment variables for conductor and sequencer-relayer components
Background
Currently,
ASTRIA_CONDUCTOR_CELESTIA_BLOCK_TIME_MSandASTRIA_SEQUENCER_RELAYER_BLOCK_TIMEenvironment variables are hard coded in the charts, the variables determines polling frequency and thus should be easily configurable.Changes
Testing
locally templating the chart with new default values.
Changelogs
No updates required