Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sequencer): refactor app #1819

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

ethanoroshiba
Copy link
Contributor

@ethanoroshiba ethanoroshiba commented Nov 18, 2024

Summary

Refactored <prepare/process>_proposal_execute_transactions methods.

Background

These methods previously contained a lot of shared code. This is meant to eliminate this code duplication and also make the steps that are happening in the proposals clearer and easier to understand.

Changes

  • Renamed prepare_proposal_execute_transactions to prepare_proposal_tx_execution to better represent that this is the execution step of the larger prepare_proposal method.
  • Renamed process_proposal_execute_transactions to process_proposal_tx_execution.
  • Refactored block size checks and tx execution to shared helper functions, which take a new enum Proposal containing information necessary for either Prepare or Process.

Testing

Passing all tests.

Changelogs

No updates required

Related Issues

closes #1785

@github-actions github-actions bot added the sequencer pertaining to the astria-sequencer crate label Nov 18, 2024
@ethanoroshiba ethanoroshiba added refactor code refactoring or maintainence docker-build used to trigger docker builds on PRs labels Nov 18, 2024
@ethanoroshiba ethanoroshiba marked this pull request as ready for review November 18, 2024 19:46
@ethanoroshiba ethanoroshiba requested a review from a team as a code owner November 18, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docker-build used to trigger docker builds on PRs refactor code refactoring or maintainence sequencer pertaining to the astria-sequencer crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sequencer: refactor app
1 participant