Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Refactored
<prepare/process>_proposal_execute_transactions
methods.Background
These methods previously contained a lot of shared code. This is meant to eliminate this code duplication and also make the steps that are happening in the proposals clearer and easier to understand.
Changes
prepare_proposal_execute_transactions
toprepare_proposal_tx_execution
to better represent that this is the execution step of the largerprepare_proposal
method.process_proposal_execute_transactions
toprocess_proposal_tx_execution
.Proposal
containing information necessary for eitherPrepare
orProcess
.Testing
Passing all tests.
Changelogs
No updates required
Related Issues
closes #1785