refactor(cli)!: break address tool out of cli #1803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SuperFluffy
force-pushed
the
superfluffy/break-out-bech32m
branch
from
5503c05 to
39d10c4
Compare
github-actions
bot
added
the
ci
SuperFluffy
added
cli
|
Currently gated on #1802 being merged into main. |
SuperFluffy
force-pushed
the
superfluffy/break-out-bech32m
branch
from
e455742 to
ee01a01
Compare
SuperFluffy
requested review from
Fraser999 and
noot
and removed request for
noot
Fraser999
approved these changes
Nov 19, 2024
There was a problem hiding this comment.
I don't think we need a changelog if this is not a crate/binary which we expect to publish or to be consumed by third-parties.
SuperFluffy
force-pushed
the
ENG-1003/address-to-crate
branch
from
c1ce512 to
0b37986
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Moves the
sequencer addresssubcommand out of the CLI into a newastria-addresstool.Background
Normal users should never have to deal with the raw hex-formatted address bytes derived from an ed25519 verification key. This functionality was (erroneously) added to astria-cli as a power user tool when migrating from the old Astria address format to the new bech32m based one.
Changes
sequencer addressfrom astria cli.tools/astria-addressbinary with expanded functionality (also allowing to constract compat/bech32 non-m addresses).Testing
Added integration tests for running
astria-addresswith various options.Added a github job to test the utility.
Changelogs
Changelogs updated.
Breaking Changelist
astria-clifor users relying on thesequencer addresssubcommand.