-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(sequencer): provide storage and snapshot types #1801
Open
Fraser999
wants to merge
7
commits into
main
Choose a base branch
from
fraser/ENG-769/storage-snapshot
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
36a4174
provide storage and snapshot types
Fraser999 60477bc
Merge remote-tracking branch 'upstream/main' into fraser/ENG-769/stor…
Fraser999 884749b
Merge remote-tracking branch 'upstream/main' into fraser/ENG-769/stor…
Fraser999 d3fdd1c
Merge remote-tracking branch 'upstream/main' into fraser/ENG-769/stor…
Fraser999 1849cae
Merge remote-tracking branch 'upstream/main' into fraser/ENG-769/stor…
Fraser999 f24f75e
Merge remote-tracking branch 'upstream/main' into fraser/ENG-769/stor…
Fraser999 5eab713
Merge remote-tracking branch 'upstream/main' into fraser/ENG-769/stor…
Fraser999 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a big effort to not have
anyhow
be a direct dependency of sequencer. Can we avoid reintroducing it here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we might be able to do that as part of #1436, but for now it's required since we're implementing
cnidarium::StateRead
on the newSnapshot
type and that requiresanyhow
(cnidarium
doesn't re-export it either).