Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(sequencer): output private key into file instead of console #1256

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Halimao
Copy link

@Halimao Halimao commented Jul 10, 2024

Summary

Writing private key to file when running astria-cli sequencer account create

Background

Addressed part of issue #594

Changes

  • Writing private key to file when running astria-cli sequencer account create
  • Update output message for private key
  • Update create_account function comment

Testing

halimao@Halimao:astria$ ./target/release/astria-cli sequencer account create
Create Sequencer Account

Public Key:  "8703d3134c9de51b6ef1fb62a87f690410f2b4291b6acfc3c8e1a6bd9f338dd2"
Address:     "1e9edbd537755379be766fb59a0a2aba1e864230"
Private Key has been output into priv.key.
Note: Do not share or lose this private key!
halimao@Halimao:astria$ cat priv.key 
*******bcd354f3226a3351747b718e591*********

Metrics

Breaking Changelist

Related Issues

closes #594

@Halimao Halimao requested a review from a team as a code owner July 10, 2024 04:34
@Halimao Halimao requested a review from noot July 10, 2024 04:34
@Halimao Halimao force-pushed the refactor/output-privkey-to-file branch from 8731c28 to 5e4ddf9 Compare July 17, 2024 01:45
@Halimao
Copy link
Author

Halimao commented Jul 27, 2024

@noot Hi sir, could you please help me review this pr

@Halimao Halimao force-pushed the refactor/output-privkey-to-file branch from ba5e536 to 6cb3241 Compare July 30, 2024 02:30
@Halimao Halimao force-pushed the refactor/output-privkey-to-file branch from a467623 to 179e44b Compare September 5, 2024 05:10
@Halimao Halimao force-pushed the refactor/output-privkey-to-file branch from 179e44b to 1252f9f Compare September 9, 2024 06:42
@joroshiba
Copy link
Member

This PR is stale because it has been open 45 days with no activity. Remove stale label or this PR will be
closed in 7 days.

@Halimao
Copy link
Author

Halimao commented Dec 11, 2024

Your team ignored contributors' PR for a long time and told me that this PR now has no activity.

Have you ever responded to the PR before?

@joroshiba joroshiba removed the stale label Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Zeroize and don't reveal private keys
2 participants