Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(conductor): avoid large enum variants #1858

Open
ethanoroshiba opened this issue Dec 6, 2024 · 0 comments · May be fixed by #1865
Open

chore(conductor): avoid large enum variants #1858

ethanoroshiba opened this issue Dec 6, 2024 · 0 comments · May be fixed by #1865
Assignees
@ethanoroshiba
Labels
code-quality conductor pertaining to the astria-conductor crate

Comments

@ethanoroshiba
Copy link
Contributor

ethanoroshiba commented Dec 6, 2024 •
edited by sync-by-unito bot
Loading

We should void having large enum variants as described here: https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant

Problem point:

astria/crates/astria-conductor/src/executor/mod.rs

Lines 70 to 90 in 7e00378

#[derive(Debug, thiserror::Error)]
pub(crate) enum FirmSendError {
#[error("executor was configured without firm commitments")]
NotSet,
#[error("failed sending blocks to executor")]
Channel {
#[from]
source: mpsc::error::SendError<ReconstructedBlock>,
},
}
#[derive(Debug, thiserror::Error)]
pub(crate) enum FirmTrySendError {
#[error("executor was configured without firm commitments")]
NotSet,
#[error("failed sending blocks to executor")]
Channel {
#[from]
source: mpsc::error::TrySendError<ReconstructedBlock>,
},
}

┆Issue Number: ENG-1039
@ethanoroshiba ethanoroshiba self-assigned this Dec 6, 2024
@ethanoroshiba ethanoroshiba added conductor pertaining to the astria-conductor crate code-quality labels Dec 6, 2024
@ethanoroshiba ethanoroshiba linked a pull request Dec 6, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ethanoroshiba ethanoroshiba

Labels
code-quality conductor pertaining to the astria-conductor crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(conductor): send boxed objects over channels astriaorg/astria
1 participant
@ethanoroshiba