-
Notifications
You must be signed in to change notification settings - Fork 77
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
chore(core, sequencer): add names to all snapshot tests (#1690)
## Summary Added names to all snapshot tests which did not have them. ## Background If a certain test had multiple snapshot assertions, they would be named based on their ordering. Hence any reordering, removal, or addition of the snapshots would break the test, which should not be the case. This change aims to fix this problem as well as establish a best practice of naming snapshots moving forward. ## Changes - Added names to all snapshot tests and regenerated all snapshots not within Conductor (due to code freeze) ## Testing Passing all tests. ## Related Issues closes #1656
- Loading branch information
1 parent
88adcb3
commit 7e00378
Showing
57 changed files
with
83 additions
and
80 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
...e__primitive__v1__tests__snapshots-2.snap → ...__tests__compat_bech32_non_m_address.snap
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
--- | ||
source: crates/astria-core/src/primitive/v1/mod.rs | ||
expression: "&bech32_address" | ||
expression: "&compat_address" | ||
--- | ||
astriacompat19g4z52329g4z52329g4z52329g4z52322jspvr |
2 changes: 1 addition & 1 deletion
2
...ore__primitive__v1__tests__snapshots.snap → ...ive__v1__tests__main_bech32m_address.snap
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
...1__tests__genesis_state_is_unchanged.snap → ...l__genesis__v1__tests__genesis_state.snap
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 1 addition & 2 deletions
3
...ics20_transfer_deposit_memo_snapshot.snap → ...__tests__ics20_transfer_deposit_memo.snap
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 1 addition & 2 deletions
3
...withdrawal_from_rollup_memo_snapshot.snap → ...s__ics20_withdrawal_from_rollup_memo.snap
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 1 addition & 2 deletions
3
..._keys__tests__keys_should_not_change.snap → ...s__storage__keys__tests__base_prefix.snap
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,5 @@ | ||
--- | ||
source: crates/astria-sequencer/src/address/storage/keys.rs | ||
assertion_line: 10 | ||
expression: BASE_PREFIX_KEY | ||
expression: BASE_PREFIX | ||
--- | ||
address/prefixes/base |
3 changes: 1 addition & 2 deletions
3
...eys__tests__keys_should_not_change-2.snap → ...rage__keys__tests__ibc_compat_prefix.snap
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,5 @@ | ||
--- | ||
source: crates/astria-sequencer/src/address/storage/keys.rs | ||
assertion_line: 11 | ||
expression: IBC_COMPAT_PREFIX_KEY | ||
expression: IBC_COMPAT_PREFIX | ||
--- | ||
address/prefixes/ibc_compat |
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 1 addition & 2 deletions
3
...eys__tests__keys_should_not_change-3.snap → ...orage__keys__tests__block_height_key.snap
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,5 @@ | ||
--- | ||
source: crates/astria-sequencer/src/app/storage/keys.rs | ||
assertion_line: 22 | ||
expression: BLOCK_HEIGHT_KEY | ||
expression: BLOCK_HEIGHT | ||
--- | ||
app/block_height |
3 changes: 1 addition & 2 deletions
3
...eys__tests__keys_should_not_change-4.snap → ...ge__keys__tests__block_timestamp_key.snap
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,5 @@ | ||
--- | ||
source: crates/astria-sequencer/src/app/storage/keys.rs | ||
assertion_line: 23 | ||
expression: BLOCK_TIMESTAMP_KEY | ||
expression: BLOCK_TIMESTAMP | ||
--- | ||
app/block_timestamp |
3 changes: 1 addition & 2 deletions
3
..._keys__tests__keys_should_not_change.snap → ...__storage__keys__tests__chain_id_key.snap
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,5 @@ | ||
--- | ||
source: crates/astria-sequencer/src/app/storage/keys.rs | ||
assertion_line: 18 | ||
expression: CHAIN_ID_KEY | ||
expression: CHAIN_ID | ||
--- | ||
app/chain_id |
3 changes: 1 addition & 2 deletions
3
...eys__tests__keys_should_not_change-2.snap → ...ge__keys__tests__revision_number_key.snap
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,5 @@ | ||
--- | ||
source: crates/astria-sequencer/src/app/storage/keys.rs | ||
assertion_line: 21 | ||
expression: REVISION_NUMBER_KEY | ||
expression: REVISION_NUMBER | ||
--- | ||
app/revision_number |
1 change: 0 additions & 1 deletion
1
...eys__tests__keys_should_not_change-5.snap → ...ge__keys__tests__storage_version_key.snap
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,5 @@ | ||
--- | ||
source: crates/astria-sequencer/src/app/storage/keys.rs | ||
assertion_line: 22 | ||
expression: storage_version_by_height(42) | ||
--- | ||
app/storage_version/42 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 0 additions & 1 deletion
1
...eys__tests__keys_should_not_change-2.snap → ...e__keys__tests__asset_key_test_asset.snap
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,5 @@ | ||
--- | ||
source: crates/astria-sequencer/src/assets/storage/keys.rs | ||
assertion_line: 87 | ||
expression: asset(&test_asset()) | ||
--- | ||
assets/ibc/be429a02d00837245167a2616674a979a2ac6f9806468b48a975b156ad711320 |
3 changes: 1 addition & 2 deletions
3
..._keys__tests__keys_should_not_change.snap → ...orage__keys__tests__native_asset_key.snap
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,5 @@ | ||
--- | ||
source: crates/astria-sequencer/src/assets/storage/keys.rs | ||
assertion_line: 84 | ||
expression: NATIVE_ASSET_KEY | ||
expression: NATIVE_ASSET | ||
--- | ||
assets/native_asset |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 1 addition & 2 deletions
3
..._keys__tests__keys_should_not_change.snap → ...orage__keys__tests__sudo_address_key.snap
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,5 @@ | ||
--- | ||
source: crates/astria-sequencer/src/authority/storage/keys.rs | ||
assertion_line: 15 | ||
expression: SUDO_STORAGE_KEY | ||
expression: SUDO | ||
--- | ||
authority/sudo |
3 changes: 1 addition & 2 deletions
3
...eys__tests__keys_should_not_change-2.snap → ...rage__keys__tests__validator_set_key.snap
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,5 @@ | ||
--- | ||
source: crates/astria-sequencer/src/authority/storage/keys.rs | ||
assertion_line: 16 | ||
expression: VALIDATOR_SET_STORAGE_KEY | ||
expression: VALIDATOR_SET | ||
--- | ||
authority/validator_set |
1 change: 0 additions & 1 deletion
1
...eys__tests__keys_should_not_change-3.snap → ...__keys__tests__validator_updates_key.snap
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,5 @@ | ||
--- | ||
source: crates/astria-sequencer/src/authority/storage/keys.rs | ||
assertion_line: 15 | ||
expression: VALIDATOR_UPDATES | ||
--- | ||
authority/validator_updates |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 0 additions & 1 deletion
1
..._keys__tests__keys_should_not_change.snap → ...eys__tests__block_hash_by_height_key.snap
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,5 @@ | ||
--- | ||
source: crates/astria-sequencer/src/grpc/storage/keys.rs | ||
assertion_line: 44 | ||
expression: block_hash_by_height(42) | ||
--- | ||
grpc/block_hash/42 |
1 change: 0 additions & 1 deletion
1
...eys__tests__keys_should_not_change-3.snap → ...tests__rollup_data_by_has_and_id_key.snap
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,5 @@ | ||
--- | ||
source: crates/astria-sequencer/src/grpc/storage/keys.rs | ||
assertion_line: 46 | ||
expression: "rollup_data_by_hash_and_rollup_id(&HASH, &ROLLUP_ID)" | ||
--- | ||
grpc/rollup_data/AQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQE=/AgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgI= |
1 change: 0 additions & 1 deletion
1
...eys__tests__keys_should_not_change-4.snap → ..._keys__tests__rollup_ids_by_hash_key.snap
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,5 @@ | ||
--- | ||
source: crates/astria-sequencer/src/grpc/storage/keys.rs | ||
assertion_line: 49 | ||
expression: rollup_ids_by_hash(&HASH) | ||
--- | ||
grpc/rollup_ids/AQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQE= |
1 change: 0 additions & 1 deletion
1
...eys__tests__keys_should_not_change-6.snap → ...eys__tests__rollup_ids_proof_by_hash.snap
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,5 @@ | ||
--- | ||
source: crates/astria-sequencer/src/grpc/storage/keys.rs | ||
assertion_line: 51 | ||
expression: rollup_ids_proof_by_hash(&HASH) | ||
--- | ||
grpc/rollup_ids_proof/AQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQE= |
1 change: 0 additions & 1 deletion
1
...eys__tests__keys_should_not_change-5.snap → ...ollup_transactions_proof_by_hash_key.snap
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,5 @@ | ||
--- | ||
source: crates/astria-sequencer/src/grpc/storage/keys.rs | ||
assertion_line: 50 | ||
expression: rollup_transactions_proof_by_hash(&HASH) | ||
--- | ||
grpc/rollup_txs_proof/AQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQE= |
1 change: 0 additions & 1 deletion
1
...eys__tests__keys_should_not_change-2.snap → ...__sequencer_block_header_by_hash_key.snap
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,5 @@ | ||
--- | ||
source: crates/astria-sequencer/src/grpc/storage/keys.rs | ||
assertion_line: 45 | ||
expression: sequencer_block_header_by_hash(&HASH) | ||
--- | ||
grpc/block_header/AQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQE= |
Oops, something went wrong.