Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(sequencer-relayer): avoid large err variant #1860

Open
ethanoroshiba opened this issue Dec 6, 2024 · 0 comments · May be fixed by #1863
Open

chore(sequencer-relayer): avoid large err variant #1860

ethanoroshiba opened this issue Dec 6, 2024 · 0 comments · May be fixed by #1863
Assignees
@ethanoroshiba
Labels
code-quality sequencer-relayer pertaining to the astria-sequencer-relayer crate

Comments

@ethanoroshiba
Copy link
Contributor

ethanoroshiba commented Dec 6, 2024 •
edited by sync-by-unito bot
Loading

Large error variants should be avoided as described here: https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err

Problem point:

astria/crates/astria-sequencer-relayer/src/relayer/write/mod.rs

Line 99 in 7e00378

) -> Result<(), TrySendError<SequencerBlock>> {

┆Issue Number: ENG-1041
@ethanoroshiba ethanoroshiba added sequencer-relayer pertaining to the astria-sequencer-relayer crate code-quality labels Dec 6, 2024
@ethanoroshiba ethanoroshiba self-assigned this Dec 6, 2024
@ethanoroshiba ethanoroshiba linked a pull request Dec 6, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ethanoroshiba ethanoroshiba

Labels
code-quality sequencer-relayer pertaining to the astria-sequencer-relayer crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(sequencer-relayer): change blob submitter to use boxed blocks astriaorg/astria
1 participant
@ethanoroshiba