Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(sequencer-relayer): avoid large enum variant #1859

Open
ethanoroshiba opened this issue Dec 6, 2024 · 0 comments
Open

chore(sequencer-relayer): avoid large enum variant #1859

ethanoroshiba opened this issue Dec 6, 2024 · 0 comments
Assignees
@ethanoroshiba
Labels
code-quality sequencer-relayer pertaining to the astria-sequencer-relayer crate testing

Comments

@ethanoroshiba
Copy link
Contributor

ethanoroshiba commented Dec 6, 2024 •
edited by sync-by-unito bot
Loading

We should avoid large enum variants as described here: https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant.

Problem point:

astria/crates/astria-sequencer-relayer/tests/blackbox/helpers/mock_sequencer_server.rs

Lines 99 to 103 in 7e00378

pub enum SequencerBlockToMount {
GoodAtHeight(u32),
BadAtHeight(u32),
Block(SequencerBlock),
}

┆Issue Number: ENG-1040
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ethanoroshiba ethanoroshiba

Labels
code-quality sequencer-relayer pertaining to the astria-sequencer-relayer crate testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(sequencer-relayer): box large enum variant astriaorg/astria
1 participant
@ethanoroshiba