-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Trusted Builder with Optimistic Simulation MVP #41
Draft
bharath-123
wants to merge
12
commits into
main
Choose a base branch
from
ENG-626/optimistic-simulation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bharath-123
changed the title
optimistic simulation
trusted builder optimistic simulation
Aug 23, 2024
bharath-123
changed the title
trusted builder optimistic simulation
feat: Trusted Builder with Optimistic Simulation
Aug 27, 2024
bharath-123
changed the title
feat: Trusted Builder with Optimistic Simulation
feat: Trusted Builder with Optimistic Simulation MCP
Aug 27, 2024
bharath-123
changed the title
feat: Trusted Builder with Optimistic Simulation MCP
feat: Trusted Builder with Optimistic Simulation MvP
Aug 27, 2024
bharath-123
changed the title
feat: Trusted Builder with Optimistic Simulation MvP
feat: Trusted Builder with Optimistic Simulation MVP
Aug 27, 2024
bharath-123
commented
Sep 6, 2024
return nil, status.Error(codes.InvalidArgument, "Could not unbundle builder bundle packet") | ||
} | ||
|
||
txsToProcess := append(tobTxs, ethTxs...) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we are merging the TOB and ROB here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Optimistic Simulation, the composer of the builder receives sequence actions from the
process_proposal
step of a full node close to it. The composer simulates its bundle on top of the sequence actions received from process_proposal and submits the simulated sequence actions if only the block containing the sequence actions is finalized. The sequence actions are submitted in aBuilderBundlePacket
artifact which indicates the transactions supposed to go to the top of block.When it comes to Astria-Geth, this involves us creating the parent block with the sequence actions received from process_proposal using
ExecuteBlock
rpc, storing it temporarily somewhere and then simulating the bundle on top of it.The following changes have been done:
tempBlock
atomic variable. This block is not inserted into the chain but is used to simulate future bundles on.ExecuteBlock
simulateOnly
mode where we do not insert the block to the chain which can save us some time during simulation.