custom precompile capabilities #36
Conversation
mycodecrafting
requested review from
bharath-123,
joroshiba and
noot
and removed request for
joroshiba and
noot
precompile/README.md
Outdated
|
|
||
| 4. Implement the precompile in Go at `./contracts/<precompile>/<precompile.go>`. | ||
| - The struct should implement the `StatefulPrecompiledContract` interface | ||
| - You must methods defined in the Solidity interface |
There was a problem hiding this comment.
I think there is a missing word here
| caller common.Address, | ||
| value *uint256.Int, | ||
| suppliedGas uint64, | ||
| readOnly bool, |
There was a problem hiding this comment.
what is the instance in which this would be true?
There was a problem hiding this comment.
it's true if the precompile is called with the STATICCALL opcode. State is not allowed to change during a STATICCALL op
precompile/bindings/.gitignore
Outdated
There was a problem hiding this comment.
why do we need the .gitignore here?
There was a problem hiding this comment.
it's here to ensure this dir exists but nothing in it can be tracked. the precompile/gen.sh scripts needs it to exist. Probably cleaner to just have that script ensure it exists and ignore the dir in a .gitignore
|
|
||
| // return precompiles that are enabled at height | ||
| func PrecompileConfig(chainConfig *params.ChainConfig, height uint64, timestamp uint64) precompile.PrecompileMap { | ||
| return NullPrecompiles |
There was a problem hiding this comment.
should we add a commented out line of code here on what enabling would look like?
There was a problem hiding this comment.
it is outlined in the readme but here probably doesn't hurt
Summary
Adds a precompile manager that makes it easy to add new precompiles to the evm by writing an implementation in go which corresponds to a defined solidity interface. These precompiles can optionally have state in the evm state db.
Background
This updates a PR from the old astria
go-ethereumrepo to the latest changes in the newerastria-gethrepo.The precompile manager is heavily utilized by Forma and potentially useful for other custom evm rollups. @itamarreif may have some ideas of things he might like to do with it.
There are no custom precompiles enabled by default.
Changes from old PR