Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve latest version instead of downloading latest release #178

Merged
merged 12 commits into from
Nov 30, 2024

Conversation

pollenjp
Copy link
Contributor

@pollenjp pollenjp commented Nov 29, 2024

Summary

Hi, this is my first contribution.

I addressed issue #171 by adjusting the uv version: latest behavior. I also added uv-cache-hit output and included CI tests (see attached image).

I look forward to your feedback.

Fig.1: success CI

image

Changes

  1. Fetch the latest version tag from the GitHub API.
  2. Proceed as with the download-cache download-version process.

@eifinger
Copy link
Collaborator

Thank you for your contribution!

Currently on my phone so a dedicated review will follow.

Can you already provide more detail on how the new output can be used?

.github/workflows/test.yml Outdated Show resolved Hide resolved
Copy link
Collaborator

@eifinger eifinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice addition. I like it alot!

.github/workflows/test.yml Outdated Show resolved Hide resolved
action.yml Outdated Show resolved Hide resolved
src/download/download-latest.ts Outdated Show resolved Hide resolved
src/setup-uv.ts Outdated Show resolved Hide resolved
src/download/download-latest.ts Outdated Show resolved Hide resolved
src/download/download-latest.ts Outdated Show resolved Hide resolved
src/setup-uv.ts Outdated Show resolved Hide resolved
src/setup-uv.ts Outdated Show resolved Hide resolved
src/setup-uv.ts Outdated Show resolved Hide resolved
src/setup-uv.ts Show resolved Hide resolved
pollenjp and others added 6 commits November 30, 2024 09:23
Co-authored-by: Kevin Stillhammer <[email protected]>
Co-authored-by: Kevin Stillhammer <[email protected]>
Co-authored-by: Kevin Stillhammer <[email protected]>
Co-authored-by: Kevin Stillhammer <[email protected]>
Co-authored-by: Kevin Stillhammer <[email protected]>
@eifinger eifinger added the enhancement New feature or request label Nov 30, 2024
Copy link
Collaborator

@eifinger eifinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really awesome. Thank you! 🎆

@eifinger eifinger changed the title Enable latest cache by calling getLatestReleaseVersion before downloading Resolve latest version instead of downloading latest release Nov 30, 2024
@eifinger eifinger merged commit 38f3f10 into astral-sh:main Nov 30, 2024
36 checks passed
@pollenjp pollenjp deleted the feature/latest-cache branch November 30, 2024 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants