Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[red-knot] Re-enable linter corpus tests #14736

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

sharkdp
Copy link
Contributor

@sharkdp sharkdp commented Dec 2, 2024

Summary

Given that no new failures appeared over the past two weeks, and seeing the fuzzing results from @dhruvmanila in #13778, I think we can re-enable these tests. We also had one regression that would have been caught by these tests, so there is some value in having them enabled.

@sharkdp sharkdp added the red-knot Multi-file analysis & type inference label Dec 2, 2024
Copy link
Contributor

@carljm carljm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me in principle. Appears there is at least one file that needs adding to KNOWN_FAILURES before this can land?

@sharkdp sharkdp force-pushed the david/reenable-linter-corpus-tests branch from 02348b2 to 5c2f84d Compare December 2, 2024 19:04
Copy link
Contributor

github-actions bot commented Dec 2, 2024

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@sharkdp
Copy link
Contributor Author

sharkdp commented Dec 2, 2024

Given that no new failures appeared over the past two weeks,

Appears there is at least one file that needs adding to KNOWN_FAILURES before this can land

Fantastic, unfortunate timing on my end 😄. I accidentally ran cargo nextest run -p red_knot_python_semantic offline, instead of -p red_knot_workspace.

This new file also contains a self-referential type alias, so this is a known problem (#14672). I added it to the corresponding section in KNOWN_FAILURES.

type K = 'K | None'

@sharkdp sharkdp merged commit 5137fcc into main Dec 2, 2024
21 checks passed
@sharkdp sharkdp deleted the david/reenable-linter-corpus-tests branch December 2, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
red-knot Multi-file analysis & type inference
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants