[pyupgrade] Do not report when a UTF-8 comment is followed by a non-UTF-8 one (UP009)
#14728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-UTF-8 one (`UP009`)
|
dscorbett
reviewed
Dec 2, 2024
| diagnostics.push(diagnostic); | ||
| [Some(CodingComment::UTF8(ranges_1)), Some(CodingComment::UTF8(ranges_2))] => { | ||
| report(diagnostics, ranges_1.line_range, ranges_1.self_range); | ||
| report(diagnostics, ranges_2.line_range, ranges_2.self_range); |
There was a problem hiding this comment.
If this block removes both UTF-8 encoding declarations, what happens if there is a third, non-UTF-8 encoding declaration?
# coding=utf-8
# coding=utf-8
# coding=asciiI think it would be better to only offer the fix for ranges_1. If it is safe to delete ranges_2 too, that can happen on the next iteration.
There was a problem hiding this comment.
Just to be clear, should we:
- Report both but only suggest a fix for the first?
- Report only the first?
- Report both, marking the first fix safe but the second fix unsafe?
- Another way?
Currently this rule is marked as always fixable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #14704.
Test Plan
cargo nextest runandcargo insta test.