[flake8-annotations] Fix parsing of "complex" forward reference type annotations in any-type (ANN401)

[sbrugman]

Summary

Fixes #14695.

The root cause was tricky to find.
"Complex" forward reference type annotations are handled differently. Forward references are "complex" in this case when the raw contents (without quotes) of the expression with the parsed contents is not contained in the string literal.

ruff/crates/ruff_python_parser/src/typing.rs

Line 65 in 84748be

if raw_contents(expr_text)

Annotations are recursively parsed, for instance:
"'int'" (complex) => "int" (simple)

The raw contents of the expression "in\x74" is not contained in the string literal int and hence requires multiple complex parsing steps: "'in\x74'" (complex) -> "in\x74" (complex). This is rare, and probably that's why the bug went unnoticed.

Parsed type annotations are cached by their start offset:

ruff/crates/ruff_linter/src/checkers/ast/mod.rs

Line 2544 in 84748be

.entry(annotation.start())

As it turned out, for these complex annotations the starting offset was not properly updated (removing the quotes), as well already do for the simple annotations. This caused an infinite loop, and eventually a stack overflow.

Test Plan

Extended the test suite with regression tests.

[github-actions]

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Formatter (stable)

✅ ecosystem check detected no format changes.

Formatter (preview)

✅ ecosystem check detected no format changes.

[dhruvmanila]

Do you think this is an issue that should be solved holistically (#10586)? Because the relocate_expr is actually incorrect in the first place.

[dhruvmanila]

As it turned out, for these complex annotations the starting offset was not properly updated (removing the quotes), as well already do for the simple annotations.

Sorry, I'm a bit confused still. Why are we using the range without quotes for the parsed expression in case of complex annotation? Because for simple annotations, we just use the range without quotes for the original string expression.