[red-knot] Implement type narrowing for boolean conditionals #14037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomerBin
requested review from
carljm,
MichaReiser,
AlexWaygood and
sharkdp
as code owners
|
carljm
requested changes
Nov 1, 2024
crates/red_knot_python_semantic/resources/mdtest/narrow/conditionals_boolean.md
Show resolved
Hide resolved
crates/red_knot_python_semantic/resources/mdtest/narrow/conditionals_boolean.md
Show resolved
Hide resolved
crates/red_knot_python_semantic/resources/mdtest/narrow/conditionals_boolean.md
Outdated
Show resolved
Hide resolved
crates/red_knot_python_semantic/resources/mdtest/narrow/conditionals_boolean.md
Show resolved
Hide resolved
crates/red_knot_python_semantic/resources/mdtest/narrow/conditionals_boolean.md
Outdated
Show resolved
Hide resolved
Thanks for the review! I'll address all comments soon |
TomerBin
force-pushed
the
tomer/type-narrow-boolean-conditionals
branch
2 times, most recently
from
bc1078e
to
06089fb
Compare
|
I think i've addressed all comments, it is ready for another review now :) |
carljm
approved these changes
Nov 4, 2024
…ionals_boolean.md Co-authored-by: Carl Meyer <[email protected]>
TomerBin
force-pushed
the
tomer/type-narrow-boolean-conditionals
branch
from
06089fb
to
1fd2402
Compare
carljm
added a commit
to Glyphack/ruff
that referenced
this pull request
Nov 5, 2024
* main: [red-knot] Implement type narrowing for boolean conditionals (astral-sh#14037)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR enables red-knot to support type narrowing based on
andandorconditionals, including nested combinations and their negation (forelif/elseblocks and fornotoperator). Part of #13694.In order to address this properly (hopefully 😅), I had to run
NarrowingConstraintsBuilderfunctions recursively. In the first commit I introduced a minor refactor - instead of mutatingself.constraints, the new constraints are now returned as function return values. I also modified the constraints map to be optional, preventing unnecessary hashmap allocations.Thanks @carljm for your support on this :)
The second commit contains the logic and tests for handling boolean ops, with improvements to intersections handling in
is_subtype_of.As I'm still new to Rust and the internals of type checkers, I’d be more than happy to hear any insights or suggestions.
Thank you!