Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for mentions and links to CloudWatch logs #42

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Support for mentions and links to CloudWatch logs #42

wants to merge 5 commits into from

Conversation

kujon
Copy link

@kujon kujon commented Jul 2, 2019

  1. You can now configure whether to mention someone using MENTION environment variable.
  2. If the CloudWatch alarm has been caused by a log metric filter, links to the appropriate logs will be included.

@CodyReichert CodyReichert self-requested a review July 2, 2019 17:37
@kujon
Copy link
Author

kujon commented Jul 31, 2019

Hi. Any chance of having it merged soon?

@lamphuc
Copy link

lamphuc commented Jul 30, 2020

Hi @CodyReichert I think this PR looks good.

As we have been using this branch ourselves for production for quite sometimes, it will be good if we can merge it to master. Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CodyReichert CodyReichert Awaiting requested review from CodyReichert

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kujon @lamphuc @CodyReichert