Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

announce port=1025 instead of port=1, when there is no listen port #7708

Open
wants to merge 4 commits into
base: RC_2_0
Choose a base branch
from

Conversation

Aurumh4x
Copy link

slight update from #4400

this was causing issues with certain trackers which block advertised listen ports less than 1024 - HDInnovations/UNIT3D-Community-Edition#3329

this was causing bugs with using libtorrent based clients (such as qbittorrent) when using socks proxy, as seen in following issues
HDInnovations/UNIT3D-Community-Edition#3428
HDInnovations/UNIT3D-Community-Edition#3847

please let me know if there are any other follow on effects from this that might require changes

Roardom added a commit to Roardom/UNIT3D-Announce that referenced this pull request Jul 18, 2024
In response to arvidn/libtorrent#7708. We prefer our peers to be connectable. A significant majority of peers in prod (80+%) are already connectable. We'll see how quickly the remaining 20% bounce back.
@MiM-MiM
Copy link

MiM-MiM commented Jul 19, 2024

This is just quite a terrible idea. Faking a new port rather than fixing the issue will only lead to trackers that liked it blocking these users getting banned. Cheating is not allowed on most sites.

@arvidn
Copy link
Owner

arvidn commented Jul 20, 2024

it does seem like a stretch to do this. Even reporting &port= at all seems wrong. I think it would be more palatable if there would at least be a setting to enable this (or some compatible) behavior.

@ErickBrown
Copy link

Makes sense, @arvidn
Rather than announce a default port, why not announce null/nil or simply use the configured listening port (regardless if it's connectable)? An advanced setting option to switch between announcing a default port, no port, or the configured listening port would address the problem as well.
From the UNIT3D perspective, they believe their logic is correct for blocking "faked" ports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants