announce port=1025 instead of port=1, when there is no listen port #7708
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
slight update from #4400
this was causing issues with certain trackers which block advertised listen ports less than 1024 - HDInnovations/UNIT3D-Community-Edition#3329
this was causing bugs with using libtorrent based clients (such as qbittorrent) when using socks proxy, as seen in following issues
HDInnovations/UNIT3D-Community-Edition#3428
HDInnovations/UNIT3D-Community-Edition#3847
please let me know if there are any other follow on effects from this that might require changes