Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DONT MERGE] feat: load limited-time offer signals on the client side #14897

Draft
wants to merge 15 commits into
base: main
Choose a base branch
from
Draft

[DONT MERGE] feat: load limited-time offer signals on the client side #14897

wants to merge 15 commits into from

Commits on Nov 22, 2024

  1. feat: lazy load partner offer expiration

    @starsirius
    starsirius committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    7ed4e58 View commit details
    Browse the repository at this point in the history

  2. feat: remove partner offer from primary label display

    @starsirius
    starsirius committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    2453b1a View commit details
    Browse the repository at this point in the history

  3. feat: reposition partner offer line; display empty line as placeholder

    @starsirius
    starsirius committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    ce62fbc View commit details
    Browse the repository at this point in the history

  4. feat: remove fetching partner offer and offered price display

    @starsirius
    starsirius committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    d46012b View commit details
    Browse the repository at this point in the history

  5. fix: only show bid timer line on auction artworks

    @starsirius
    starsirius committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    f3a444a View commit details
    Browse the repository at this point in the history

  6. refactor: use fixed height rather than fixed number of lines

    @starsirius
    starsirius committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    b1851ea View commit details
    Browse the repository at this point in the history

  7. fix: do not render partner offer line with no offer

    @starsirius
    starsirius committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    0d63c95 View commit details
    Browse the repository at this point in the history

  8. feat: overwrite public pricing after fetching offers

    @starsirius
    starsirius committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    320bced View commit details
    Browse the repository at this point in the history

  9. feat: don't render primary label when there is a partner offer 

    This depends on MP change that removes partner offers from primary
labels. Primary label should only consist of unauthenticated data.
    @starsirius
    starsirius committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    3ca3a17 View commit details
    Browse the repository at this point in the history

  10. feat: move limited-time offer back to the badge line 

    Now we have to consider partner offer (that's loaded on the client side)
when displaying "increased interest" and "curtors' pick" badges (that
can be loaded on the server and cached), it may visually look better
moving the limited-time offer back to the first line, with the badges.
While there will be some content shift, we can preserve the original
collector signals design (vs. partially porting over the app design).
    @starsirius
    starsirius committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    646f313 View commit details
    Browse the repository at this point in the history

  11. refactor: extract SaleMessage component and query renderer

    @starsirius
    starsirius committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    e874df2 View commit details
    Browse the repository at this point in the history

  12. test: add tests

    @starsirius
    starsirius committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    642637b View commit details
    Browse the repository at this point in the history

  13. fix: fix types

    @starsirius
    starsirius committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    7c6dc60 View commit details
    Browse the repository at this point in the history

  14. refactor: DRY

    @starsirius
    starsirius committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    55e1867 View commit details
    Browse the repository at this point in the history

  15. test: act before assertion

    @starsirius
    starsirius committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    da81774 View commit details
    Browse the repository at this point in the history