Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supporting cordova-cli@9 or cordova-lib@9 #1034

Open
wants to merge 73 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
73 commits
Select commit Hold shift + click to select a range
2e1fae3
Supporting cordova-cli@9 or cordova-lib@9
sagrawal31 Mar 27, 2019
08f9b17
Trying to fix the build
sagrawal31 Apr 3, 2019
609211e
Removing old cordova-android because of a failing test case
sagrawal31 Apr 3, 2019
a2c57ad
Only installing xcode for ios platform
sagrawal31 Apr 3, 2019
247b6a2
Fixing old failing Android tests by not installing the cordova & plat…
sagrawal31 Apr 3, 2019
46a7bd1
Fixes issues cause by Firebase SDK updates on 5 April 2019 (https://f…
dpa99c May 7, 2019
eee2cfe
Remove obsolete <service> entry for FirebasePluginInstanceIDService.
dpa99c May 14, 2019
17eb7c4
Remove unnecessary extra <config-file> block which can lead to race c…
dpa99c Mar 1, 2019
289706f
Remove redundant build-extras.gradle
dpa99c Jan 14, 2019
ad537b6
Merge pull request #2 from wizpanda/firebase-changes
sagrawal31 May 17, 2019
878a4c5
3.0.0
sagrawal31 May 17, 2019
2333790
Updating README.md
sagrawal31 May 17, 2019
385ce85
Adding npm version badge.
sagrawal31 May 21, 2019
ffec9e3
Added ability to log js stack trace on android.
Jun 10, 2019
b674176
Missed adding file to plugin.xml
Jun 10, 2019
42c66b0
Fixed error if stacktrace is missing data and js bug if stackTrace wa…
Jun 10, 2019
c1d4d10
Fixed ios error logging and added ability to log stack traces.
Jun 12, 2019
bd921fa
Add createChannel function for Android 0
maximilianloy Jun 14, 2019
3046ef9
Merge pull request #9 from maximilianloy/android-createchannel
sagrawal31 Jun 17, 2019
1911802
Formatted the code
sagrawal31 Jun 17, 2019
b8eb565
Only changing the indentation to 4 spaces.
sagrawal31 Jun 17, 2019
06de856
3.1.0
sagrawal31 Jun 17, 2019
b8ec09f
Trying to fix the Travis CI build.
sagrawal31 Jun 17, 2019
809d7f5
Merge branch 'master' into master
distinctdan Jun 19, 2019
b50e88d
Merge pull request #8 from distinctdan/master
sagrawal31 Jun 19, 2019
bfd4bf6
Some code cleanup and changes to log stacktrace in Firebase.
sagrawal31 Jun 19, 2019
428f306
3.2.0
sagrawal31 Jun 19, 2019
680ac02
Backward compatibility fixes to support breaking changes released by …
sagrawal31 Jun 19, 2019
32f40c7
Merge pull request #14 from wizpanda/firebase-breaking-backward
sagrawal31 Jun 19, 2019
cd3abfd
3.3.0
sagrawal31 Jun 19, 2019
92af2ff
First version of changes to make the app build after breaking changes…
sagrawal31 Jun 18, 2019
f72326d
Changing the minimum required cordova-android version to 8.0.0
sagrawal31 Jun 18, 2019
0379213
Updating README.md
sagrawal31 Jun 19, 2019
bc4cf4e
Merge pull request #13 from wizpanda/google-breaking-changes
sagrawal31 Jun 19, 2019
ed019d1
GitHub issue template cleanup. Updating JS files to use "const" or "l…
sagrawal31 Jun 19, 2019
066042f
4.0.0
sagrawal31 Jun 19, 2019
65e6925
Formatting plugin.xml to use 4 spaces.
sagrawal31 Jun 19, 2019
5219529
Fixed typo in firebase-browser.js fixes #16
sagrawal31 Jun 19, 2019
9d968eb
Only formatting the JS files.
sagrawal31 Jun 19, 2019
688b634
4.0.1
sagrawal31 Jun 19, 2019
6a965f6
Breaking Change: Merging `logJSError` to `logError` method for consis…
sagrawal31 Jun 24, 2019
03ee4ff
Updating the API doc.
sagrawal31 Jun 24, 2019
d72c302
Generated "Table of Contents" via markdown-toc generator.
sagrawal31 Jun 24, 2019
a2a1377
Handling a few edge cases for "logError" method.
sagrawal31 Jun 24, 2019
70b2c6c
Updating README.
sagrawal31 Jun 24, 2019
999f666
Merge pull request #21 from wizpanda/android-fixes
sagrawal31 Jun 24, 2019
e4d4dc0
Merge pull request #1 from wizpanda/master
distinctdan Jun 24, 2019
263507e
Added more docs for passing a stacktrace to logError
distinctdan Jun 24, 2019
0d798b5
Merge pull request #22 from distinctdan/master
sagrawal31 Jun 25, 2019
e60cd91
4.1.0
sagrawal31 Jun 25, 2019
b175b42
Updating CHANGELOG & docs.
sagrawal31 Jun 25, 2019
818f0cf
Breaking Change: Moving to CocoaPods to manage Firebase, Crashlytics …
sagrawal31 Jun 24, 2019
0d4719d
Using optimistic operator to specify Firebase dependencies for iOS.
sagrawal31 Jun 24, 2019
1e8a384
Updating README.
sagrawal31 Jun 25, 2019
b86af91
More clear documentation about different cordova platform versions.
sagrawal31 Jun 25, 2019
08d71bd
Merge pull request #23 from wizpanda/ios-pods
sagrawal31 Jun 25, 2019
dcfd859
5.0.0
sagrawal31 Jun 25, 2019
ebf3191
Updating README.
sagrawal31 Jun 25, 2019
72ee4fc
Fix for ampersand in the app name
teknepal Jun 25, 2019
f8bfb82
Reducing the Firebase iOS dependencies to 5.x to avoid breaking changes.
sagrawal31 Jun 27, 2019
310bbf7
Removed deprecated method "getInstanceId"
sagrawal31 Jun 27, 2019
fe059bf
Merge pull request #28 from wizpanda/ios-fixes
sagrawal31 Jun 27, 2019
1a0f3e7
5.1.0
sagrawal31 Jun 27, 2019
dc7f9ad
changed const to var
teknepal Jun 28, 2019
d4fa7f6
Merge pull request #26 from teknepal/fix_ampersand_app_name
sagrawal31 Jul 1, 2019
c1539e4
Improving the JS code. Using chalk to highlights a few logs.
sagrawal31 Jul 1, 2019
487f3be
Some docs improvement.
sagrawal31 Jul 1, 2019
5b1a526
Merge pull request #30 from wizpanda/js-improvement
sagrawal31 Jul 1, 2019
d1c5774
Some more logging improvement.
sagrawal31 Jul 1, 2019
19828d1
5.1.1
sagrawal31 Jul 1, 2019
645d5f3
Using tabular format for different version of plugin.
sagrawal31 Jul 14, 2019
eb15341
Moving the difference doc on the top & some cleanup.
sagrawal31 Jul 14, 2019
154596a
Updating README for diverting developers to new repository.
sagrawal31 Jul 25, 2019
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .editorconfig
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ trim_trailing_whitespace = true

[{package.json,.travis.yml}]
indent_style = space
indent_size = 2
indent_size = 4

[{plugin.xml,Makefile}]
indent_style = tab
29 changes: 19 additions & 10 deletions .github/ISSUE_TEMPLATE/bug_report.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,38 +4,47 @@ about: Create a report to help us improve

---

**Describe the bug**
## Describe the bug

A clear and concise description of what the bug is.

**To Reproduce**
## To Reproduce

Steps to reproduce the behavior:
1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error

**Expected behavior**
## Expected behavior

A clear and concise description of what you expected to happen.

**Screenshots**
## Screenshots

If applicable, add screenshots to help explain your problem.

**Console Logs**
## Console Logs

If applicable, provide console logs showing the errors being reported.

**Plugin Version**
Run `cordova plugin list` to find out what version of cordova-plugin-firebase you are running with
## Plugin Version

Run `cordova plugin list` to find out what version of `cordova-plugin-firebase-lib` you are running with

## Desktop (please complete the following information):

**Desktop (please complete the following information):**
- OS: [e.g. iOS]
- Browser [e.g. chrome, safari]
- Version [e.g. 22]

**Smartphone (please complete the following information):**
## Smartphone (please complete the following information):

- Device: [e.g. iPhone6]
- OS: [e.g. iOS8.1]
- Browser [e.g. stock browser, safari]
- Version [e.g. 22]

**Additional context**
## Additional context

Add any other context about the problem here.
12 changes: 8 additions & 4 deletions .github/ISSUE_TEMPLATE/feature_request.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,18 @@ about: Suggest an idea for this project

---

**Is your feature request related to a problem? Please describe.**
## Is your feature request related to a problem? Please describe.

A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

**Describe the solution you'd like**
## Describe the solution you'd like

A clear and concise description of what you want to happen.

**Describe alternatives you've considered**
## Describe alternatives you've considered

A clear and concise description of any alternative solutions or features you've considered.

**Additional context**
## Additional context

Add any other context or screenshots about the feature request here.
3 changes: 2 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,5 @@
.build-browser
package-lock.json
node_modules
cordova-plugin-firebase.code-workspace
lib/
!scripts/lib
5 changes: 4 additions & 1 deletion .npmignore
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,7 @@
package-lock.json
node_modules
test
cordova-plugin-firebase.code-workspace
lib/
.github/
docs/
cordova-plugin-firebase-lib.code-workspace
28 changes: 15 additions & 13 deletions .travis.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
env:
global:
- ANDROID_API_LEVEL=28
- ANDROID_BUILD_TOOLS_VERSION=28.0.3
- JAVA_HOME=/usr/lib/jvm/java-8-oracle
- LANG=en_US.UTF-8

Expand All @@ -10,10 +12,10 @@ matrix:
language: android
android:
components:
- tools-26.0.0
- platform-tools-26.0.0
- build-tools-26.0.0
- android-26.0.0
- tools
- platform-tools
- build-tools
- android
- extra-google-google_play_services
- extra-google-m2repository
- extra-android-m2repository
Expand All @@ -26,17 +28,17 @@ matrix:
- android-sdk-preview-license-.+
- android-sdk-license-.+
- google-gdk-license-.+
env: CORDOVA_VERSION="6.5.0" CORDOVA_PLATFORM="android" CORDOVA_PLATFORM_VERSION="6.4.0"
env: CORDOVA_VERSION="9.0.0" CORDOVA_PLATFORM="android" CORDOVA_PLATFORM_VERSION="8.0.0"

- os: linux
sudo: false
language: android
android:
components:
- tools-26.0.0
- platform-tools-26.0.0
- build-tools-26.0.0
- android-26.0.0
- tools
- platform-tools
- build-tools
- android
- extra-google-google_play_services
- extra-google-m2repository
- extra-android-m2repository
Expand All @@ -56,10 +58,10 @@ matrix:
language: android
android:
components:
- tools-26.0.0
- platform-tools-26.0.0
- build-tools-26.0.0
- android-26.0.0
- tools
- platform-tools
- build-tools
- android
- extra-google-google_play_services
- extra-google-m2repository
- extra-android-m2repository
Expand Down
86 changes: 36 additions & 50 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,73 +1,59 @@
# Version 2.0.5
# Change Log

### Bug Fixes
- <a href="https://github.com/arnesson/cordova-plugin-firebase/issues/897">#897</a>: Fixed issue with after_prepare hook not copying required files
## v5.1.1

# Version 2.0.4
1. Common: Handling ampersand in app name.
2. Build: Improving JavaScript code and logging more information.

### Bug Fixes
- <a href="https://github.com/arnesson/cordova-plugin-firebase/issues/866">#866</a>: Fixed issue with loading .plist file on some iOS devices
## v5.1.0

# Version 2.0.3
1. iOS: Downgrading the Firebase iOS dependency to 5.x to make the iOS app build fixed.
2. Common: Removed deprecated `getInstanceId` method. Use `getToken` instead.

### Features
- <a href="https://github.com/arnesson/cordova-plugin-firebase/pull/874">#874</a>: Added new api `setCrashlyticsUserId` which allows setting Crashlytics user identifier
- <a href="https://github.com/arnesson/cordova-plugin-firebase/pull/861">#861</a>: Updated `verifyPhoneNumber` api on android to add the following properties to the returned object:
- `code` - sms code
- `verified` - whether or not the verification was successful
## v5.0.0

### Bug Fixes
- <a href="https://github.com/arnesson/cordova-plugin-firebase/issues/869">#869</a>: Replace add/remove hooks with install/uninstall hooks to ensure proper configuration of the plugin
- <a href="https://github.com/arnesson/cordova-plugin-firebase/pull/870">#870</a>: Add error handling to `fetch` api on iOS
1. iOS: Using CocoaPods to manage Firebase dependencies hence requires `cordova-cli` to be minimum `v9.0.0`.
2. Docs: Detailed instructions to get the Cordova environment versions and different major releases to be used.

# Version 2.0.2
## v4.1.0

### Bug Fixes
- <a href="https://github.com/arnesson/cordova-plugin-firebase/issues/837">#837</a>: Fixed android build
1. Breaking change: Removed method `logJSError` (introduced in v3.2.0) and merged that into `logError` message.
2. Android: Handling a few edge cases for `logError` method.
3. Docs: Generating "Table of Contents" for README & API docs.

# Version 2.0.1
## v4.0.1

### Bug Fixes
- <a href="https://github.com/arnesson/cordova-plugin-firebase/pull/836">#836</a>: Fixed Crashlytics on iOS
- <a href="https://github.com/arnesson/cordova-plugin-firebase/pull/830">#830</a>: Fixed initialization of firebase services
1. Fixed typo in `firebase-browser.js`

# Version 2.0.0
## v4.0.0 - Breaking Change

### Features
- <a href="https://github.com/arnesson/cordova-plugin-firebase/issues/796">#796</a>: Update Firebase SDK Version to 5.x
1. Stop supporting `cordova-android 7.x.x`. Minimum `cordova-android 8.0.0` is required.
2. Fix the failing build due to breaking changes released by Google Firebase on Jun 17, 2019.

### Bug Fixes
- <a href="https://github.com/arnesson/cordova-plugin-firebase/issues/822">#822</a>: Can't use initFirebase() on 1.1.3 [Firebase isn't initialized]
- <a href="https://github.com/arnesson/cordova-plugin-firebase/issues/827">#827</a>: doc missing: initFirebase call needed before anything
- <a href="https://github.com/arnesson/cordova-plugin-firebase/pull/824">#824</a>: Removed initRemoteConfig method
## v3.3.0

# Version 1.1.4 (deprecated)
1. Backward compatibility fixes to support breaking changes released by Google Firebase on Jun 17, 2019.

This version has been deprecated due to complications with PR <a href="https://github.com/arnesson/cordova-plugin-firebase/pull/784">#784</a>
## v3.2.0

# Version 1.1.3 (deprecated)
1. Added ability to log JavaScript stacktrace with a new method `logJSError`. Thanks to [distinctdan](https://github.com/distinctdan) for
[PR#8](https://github.com/wizpanda/cordova-plugin-firebase-lib/pull/8).

This version has been deprecated due to complications with PR <a href="https://github.com/arnesson/cordova-plugin-firebase/pull/784">#784</a>
## v3.1.0

# Version 1.1.2 (deprecated)
1. Add `createChannel` function for Android O.

This version has been deprecated due to complications with PR <a href="https://github.com/arnesson/cordova-plugin-firebase/pull/784">#784</a>
## v3.0.0

# Version 1.1.1 (deprecated)
First version under [Wiz Panda](https://www.wizpanda.com/).

This version has been deprecated due to complications with PR <a href="https://github.com/arnesson/cordova-plugin-firebase/pull/784">#784</a>
1. Cordova@9 support
2. Fixes issues cause by Firebase SDK updates on [5 April 2019](https://firebase.google.com/support/release-notes/android#update_-_april_05_2019).
Thanks to [Dave Alden](https://github.com/dpa99c) for [commit](https://github.com/wizpanda/cordova-plugin-firebase-lib/commit/46a7bd1c06434fb4c5a72c2c20ae5d951a2e37f4)
3. Remove obsolete <service> entry for FirebasePluginInstanceIDService. Thanks to [Dave Alden](https://github.com/dpa99c) for [commit](https://github.com/wizpanda/cordova-plugin-firebase-lib/commit/eee2cfe845e6c2466d4c7fcb69d70c0c8840ea6b)
4. Remove unnecessary extra <config-file> block which can lead to race condition. Thanks to [Dave Alden](https://github.com/dpa99c) for [commit](https://github.com/wizpanda/cordova-plugin-firebase-lib/commit/17eb7c46176d5ad28fc93b53a2c49d9e6ed1888b)
5. Remove redundant build-extras.gradle. Thanks to [Dave Alden](https://github.com/dpa99c) for [commit](https://github.com/wizpanda/cordova-plugin-firebase-lib/commit/289706fc30fe848de082c468440c91ffecdce97d)

# Version 1.1.0 (deprecated)
## For older versions

This version has been deprecated due to complications with PR <a href="https://github.com/arnesson/cordova-plugin-firebase/pull/784">#784</a>

# Version 1.0.5

To force cordova to use this version, add the following to your project's config.xml:
```
<plugin name="cordova-plugin-firebase" spec="1.0.5" />
```
or by running:
```
cordova plugin add [email protected] --save
```
See the https://github.com/arnesson/cordova-plugin-firebase/blob/v2.0.5/CHANGELOG.md
65 changes: 0 additions & 65 deletions CONTRIBUTING.md

This file was deleted.

1 change: 0 additions & 1 deletion PULL_REQUEST_TEMPLATE.md

This file was deleted.

Loading