Add live_component update event handling #103
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Much like the events already handled, the live_component update event, which is triggered whenever live components are updated. Closes #102
tombruijn
approved these changes
Nov 22, 2024
This comment has been minimized.
This comment has been minimized.
|
Is there a test setup to try it out with? |
This comment has been minimized.
This comment has been minimized.
Yes, there's a live component in the live view in https://github.com/appsignal/test-setups/blob/phoenix-1.7.2/elixir/phoenix-example/app/lib/appsignal_phoenix_example_web/live/demo_live.ex, which sends an update message on page load. |
This comment has been minimized.
This comment has been minimized.
|
@jeffkreeftmeijer Thank you, looks great! Could you also open a PR to merge the new test setup? |
unflxw
approved these changes
Nov 28, 2024
This comment has been minimized.
This comment has been minimized.
1 similar comment
This is a message from the daily scheduled checks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Much like the events already handled, the live_component update event, which is triggered whenever live components are updated.
Closes #102