Erv2: Implement resource reconciliation dependencies #4785
+106
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chassing
reviewed
Dec 2, 2024
| except ExternalResourceValidationError as e: | ||
| self.errors[key] = e | ||
| continue | ||
|
|
||
| reconciliation = Reconciliation( | ||
| key=key, | ||
| resource_hash=resource.hash(), | ||
| input=self._serialize_resource_input(resource), | ||
| input=resource.json(), |
There was a problem hiding this comment.
Looks like _serialize_resource_input isn't in use anymore. Please remove it.
There was a problem hiding this comment.
It's already removed.
| def find_linked_resources( | ||
| self, spec: ExternalResourceSpec | ||
| ) -> set[ExternalResourceKey]: | ||
| return set() |
There was a problem hiding this comment.
Please add a doc string here, mainly because it's the base class.
lechuk47
force-pushed
the
erv2/trigger_dependencies
branch
from
6459d42
to
631a47d
Compare
chassing
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements resource reconciliation dependencies.
The main use case for now is RDS read replicas. Every time a Primary is reconciled, it will trigger a reconciliation for its read replicas. This is needed to sync the credentials output secrets in case a password reset is requested.