Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add typed queries for schemas #4716

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add typed queries for schemas #4716

wants to merge 1 commit into from

Conversation

maorfr
Copy link
Contributor

@maorfr maorfr commented Oct 7, 2024

to be used for something for sure

@maorfr maorfr requested a review from fishi0x01 October 7, 2024 10:32
@fishi0x01
Copy link
Contributor

fishi0x01 commented Oct 7, 2024 •
edited
Loading

Looks like a bug in qenerate. Seems it doesnt handle the enum types well (it should be strings).

reconcile/gql_definitions/common/schemas.py:50: error: Name "TypeKind" is not defined  [name-defined]

I do not have a quickfix right now ready for this - would need to look into it more deeply.

Created https://issues.redhat.com/browse/APPSRE-10983

In fact, we are not handling object enums properly https://github.com/app-sre/qenerate/blob/main/qenerate/plugins/pydantic_v1/typed_ast.py#L108-L109

@maorfr maorfr mentioned this pull request Oct 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fishi0x01 fishi0x01 Awaiting requested review from fishi0x01

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maorfr @fishi0x01