Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dynatrace-token-provider] add qontract integration annotation #4223

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[dynatrace-token-provider] add qontract integration annotation #4223

wants to merge 1 commit into from

Conversation

maorfr
Copy link
Contributor

@maorfr maorfr commented Mar 21, 2024

to be a little consistent with standard qontract resource annotation, and to provide a hint on the Secret that lands on clusters as to what owns it.

@maorfr maorfr requested a review from OliviaHY March 21, 2024 09:55
fishi0x01
fishi0x01 approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@fishi0x01 fishi0x01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

After rebase this also needs to be added to the test fixture

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fishi0x01 fishi0x01 fishi0x01 approved these changes

@OliviaHY OliviaHY OliviaHY approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maorfr @OliviaHY @fishi0x01