Convert MongoDB tutorial to PHP Attributes #2079
Merged
+31
−70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
api-platform/doctrine-odm is required but mapping.paths automatically contains ODM Document dir
GromNaN
commented
Nov 29, 2024
|
|
||
| mapping: | ||
| paths: | ||
| ['%kernel.project_dir%/src/Entity', '%kernel.project_dir%/src/Document'] |
There was a problem hiding this comment.
This configuration is not necessary as is it by default.
https://github.com/api-platform/core/blob/de3bed269838556d46899e78ed5603b7e6229e8b/src/Symfony/Bundle/DependencyInjection/ApiPlatformExtension.php#L399-L401
| */ | ||
| public $product; | ||
| #[ODM\Id(strategy: 'INCREMENT', type: 'int')] | ||
| private int $id; |
Comment on lines
-54
to
+55
| - MONGO_INITDB_DATABASE=api | ||
| - MONGO_INITDB_ROOT_USERNAME=api-platform | ||
| - MONGODB_INITDB_DATABASE=api | ||
| - MONGODB_INITDB_ROOT_USERNAME=api-platform |
There was a problem hiding this comment.
Replacing legacy env vars from the mongo docker image, with the new env vars that works with mongodb/mongodb-atlas-local and mongodb/mongodb-community-server.
dunglas
approved these changes
Nov 30, 2024
|
Cool! |
|
Thank you very much @GromNaN! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I replayed the tutorial to make sure it was still valid. A few updates (in comments).