feat(sunburst): Added some options to adjust Sunburst chart view: innerRadius, outerRadius, donut, showNulls

[bwa84]

SUMMARY

Added some options to adjust Sunburst chart:

• showNulls: allow to show / hide slices with null value
• donut: allow to switch between donut / circle view (donut was fixed before)
• innerRadius: allow to adjust inner radius when donut is checked
• outerRadius: allow to adjust outer radius

AFTER SCREENSHOT / VIDEO

sunburst_demo.mov

TESTING INSTRUCTIONS

• create or edit sunburst chart
• switch to Customize control page
• play with "Donut", "Inner Radius", "Outer Radius" & "Show values" options

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[github-actions]

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

[rusackas]

After screenshots (or video) of the controls in effect might help. I've started CI, and will hopefully remember to come back and spin up a test deployment if it passes.

[bwa84]

After screenshots (or video) of the controls in effect might help. I've started CI, and will hopefully remember to come back and spin up a test deployment if it passes.

After screenshot was added previously, now I added video also.

[bwa84]

Found bug with cross-filtering. Converting to draft for now.

[bwa84]

Little hint for beginner needed.
Bug that I found is not connected with this PR (checked in master & v4.0.1 release).
Can I fix it in this PR or should I fix it in a separate one?

[villebro]

Little hint for beginner needed. Bug that I found is not connected with this PR (checked in master & v4.0.1 release). Can I fix it in this PR or should I fix it in a separate one?

@bwa84 please feel free to address the bug in this PR if it seems doable as a bycatch fix. But if it's a substantial change, having a dedicated PR for it could be advisable.

[villebro]

This will change how all current sunburst charts are rendered. While I'm not strongly against/for this, I'm not sure we want to forcefully change all current charts. For this reason I would recommend changing the defaults to align with the current behavior, and defer changing the defaults to a later date when there's been a decision to to change the defaults. Maybe we could discuss changing the defaults for the pie chart and sunburst chart in a forthcoming town hall? CC @rusackas @michael-s-molina

[bwa84]

Default values were set with the same values that were hardcoded (innerRadius = 30, outerRadius = 70) or to keep current default behavior (donut = true, showNulls = true).