Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-50432] Remove workaround for THRIFT-4805 #48980

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pan3793
Copy link
Member

@pan3793 pan3793 commented Nov 27, 2024

What changes were proposed in this pull request?

Remove workaround for THRIFT-4805 in log4j2 configuration files.

Why are the changes needed?

SPARK-47018 upgrades Thrift 0.16, and THRIFT-4805 was fixed in Thrift 0.13.

Does this PR introduce any user-facing change?

Affects default logs a little.

The existing logging filter rules use a regex to filter out the noisy logs caused by THRIFT-4805, while other problems may also produce similar logs and silently be dropped, this change restores that.

How was this patch tested?

Review.

Was this patch authored or co-authored using generative AI tooling?

No.

@github-actions github-actions bot added the SQL label Nov 27, 2024
@pan3793
Copy link
Member Author

pan3793 commented Nov 27, 2024

cc @yaooqinn @wangyum

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants