Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-50421]fix executor related memory config incorrect when multiple resource profile worked #48963

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

zjuwangg
Copy link

@zjuwangg zjuwangg commented Nov 26, 2024

What changes were proposed in this pull request?

Reset the executor's env memory related config when resource profile is not as the default resource profile!

Why are the changes needed?

When multiple resource profile exists in the same spark application, now the executor's memory related config is not override by resource profile's memory size, which will cause maxOffHeap in UnifiedMemoryManager is not correct.
See https://issues.apache.org/jira/browse/SPARK-50421 for more details

Does this PR introduce any user-facing change?

No

How was this patch tested?

To be added

Was this patch authored or co-authored using generative AI tooling?

No

@github-actions github-actions bot added the CORE label Nov 26, 2024
@zjuwangg
Copy link
Author

@tgravescs Would you help to review this commit?

@zjuwangg zjuwangg changed the title [SPARK-50421][wip]fix executor related memory config incorrect when multiple resource profile worked [SPARK-50421]fix executor related memory config incorrect when multiple resource profile worked Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant