[improve][site] Doc changes to support peekMessages with Offset in admin-api-topics #840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@shravannarayan-es I converted the PR to draft because the PIP's PR hasn't been merged yet. |
asafm
reviewed
Mar 14, 2024
| @@ -522,6 +522,28 @@ admin.topics().peekMessages(topic, subName, numMessages); | |||
|
|
|||
| </TabItem> | |||
|
|
|||
| </Tabs> | |||
There was a problem hiding this comment.
Seems you targeted 2.11.x file, but your PIP implementation is targeted at master which is 3.2, no?
| ```` | ||
| ### Peek messages with Offset | ||
|
|
||
| You can also start to peek number of messages for a specific subscription of a given topic from a particular offset position in the following ways. |
There was a problem hiding this comment.
start?
Maybe
You can peek a number of messages, for a specific subscription of a topic, from a given offset position, in the following ways:
|
|
||
| You can also start to peek number of messages for a specific subscription of a given topic from a particular offset position in the following ways. | ||
|
|
||
| ````mdx-code-block |
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds doc for PIP-332 PR